danielfm / pybreaker

Python implementation of the Circuit Breaker pattern.
BSD 3-Clause "New" or "Revised" License
508 stars 74 forks source link

Improve type annotation on `CircuitBreakerState` #70

Closed Kludex closed 2 years ago

Kludex commented 2 years ago

I'd like to add type annotation on the whole module. Would you mind? Python 3.6 supports it just fine. 😗

danielfm commented 2 years ago

I'm not familiar with this, not really working with Python anymore, so pretty sure there are lots of new language features I'm not aware.

I'll take a look into this.

Thanks for the contributions you've made!

danielfm commented 2 years ago

Can you rebase this with the current master branch? Just as a final check before merging.

Kludex commented 2 years ago

Done 👍

danielfm commented 2 years ago

Thanks!