search

danielfm / smudge

Control the Spotify app from within Emacs.
https://asciinema.org/a/218654
GNU General Public License v3.0
313 stars 47 forks source link

Submit to MELPA? #44

Closed jkdufair closed 3 years ago

jkdufair commented 5 years ago

@danielfm What do you think about submitting to MELPA? Then I could make a lyrics package that depends on this package? I don't mind doing the work to make this happen if you think it's a good idea.

danielfm commented 5 years ago

That would be awesome. At one point I tried doing this, but it wasn't clear how the whole submission process works.

If you have some insights on that, I'd be happy to help.

andersjohansson commented 5 years ago

There is already a package called "spotify" in melpa: https://melpa.org/#/spotify. It does not seem to be as full-featured or maintained though. But something has to be done about naming in any case...

(I accidentally installed the wrong package through melpa).

jkdufair commented 5 years ago

@danielfm looks like the package would have to use a GPL compatible license. Are you interested in licensing this under one of those? https://www.gnu.org/licenses/license-list.en.html#GPLCompatibleLicenses

jkdufair commented 5 years ago

Sorry. I overlooked that you are distributing under the New BSD license. I can make updates to make it MELPA-friendly.

jkdufair commented 5 years ago

@andersjohansson Too many spotify packages! @danielfm Maybe we should call this one SpotEmacs or Spottymacs or something.

jkdufair commented 3 years ago

@danielfm I've hesitated to submit to MELPA due to random errors I'm still getting. I spent some time today trying to get to the bottom of them, and they may be intractable with the current state of Emacs & url retrieval. We may end up having to actually launch a subprocess with curl or something. Still digging. Any thoughts would be welcome. I put the question out to the hive mind too 😂

https://www.reddit.com/r/emacs/comments/lb75k9/stuck_process/

danielfm commented 3 years ago

I always hated the standard way of handling HTTP in Emacs, and on top of that the OAuth2 implementation using those advice thingies just makes things worse.

Maybe we can replace all this with some modern HTTP client implementation, but I'm not aware if there are any obvious choice already available.

jkdufair commented 3 years ago

@danielfm I think I'll play with request.el https://github.com/tkf/emacs-request. I'll open an issue for it. Love to get this stable and on Melpa

jkdufair commented 3 years ago

@danielfm I feel like things are ready to go for MELPA. I'm looking through documentation and such. I'll have a PR soon with package config & double checking linting & such.

The biggest issue I see is that, as @andersjohansson mentioned, there is indeed already a "spotify" on MELPA. Which means they'll probably require a new name (and a new function "namespace" - ugh elisp). Any thoughts? The only things that came to mind for me are "SpotEmacs", "Spottymacs", "SpotIt". None of them seem amazing. What do you think? Or maybe something like just a synonym of "spot" - "Speckle"? "Splotch"? "Dot"?

danielfm commented 3 years ago

I suck at naming things as well.

What about spotify-controller, or something? Does that give you any ideas?

gerardet46 commented 3 years ago

I suck at naming things as well.

What about spotify-controller, or something? Does that give you any idea?

spotify-client maybe

jkdufair commented 3 years ago

@danielfm I started refactoring in a branch, using spotemacs, knowing I could just search and replace if we settle on something else. It's kind of growing on me. Do you hate "spotemacs"?

danielfm commented 3 years ago

Don't know if spotemacs will grow on me as well, but right now I like spotify-client better. 😅

jkdufair commented 3 years ago

Sounds good. I’ll use that!

jkdufair commented 3 years ago

@danielfm One thing occurred to me that does recommend the name "spotemacs" is that it's substantially shorter. My understanding is that each file's definitions have to be prefixed with the package name. I hope I understand that correctly. So everything in spotify-client-controller.el would be, i.e. spotify-client-controller-xyz-function. I'm concerned that Is there any shorter name you might like? No biggie. Just thought I'd bring up the length question.

Kagia001 commented 3 years ago

spotify-client has one fatal flaw: google. When you try to google "emacs spotify-client" you would probably also get results for a lot of other spotify clients for emacs. It also sounds pretty generic.

Just throwing some names in here: SMACKS (Spotify MAC(K)roS) fis (Fis Is Spotify, fis also is f# in german) smudge (synonym for spot) topo (apparently a TOpographic POint is a synonym for spot, but mostly just because topo rolls off the tongue nicely)

jkdufair commented 3 years ago

I'm afraid I have to agree with @Kagia001. I do feel like some more unique name would be great. Any of the unique suggestions works for me. "Speckle", "Splotch", and "Smudge" are probably my favorites at this point.

danielfm commented 3 years ago

I liked smudge 😄

jkdufair commented 3 years ago

Alrighty. Smudge it is! Thankfully, Google has very little that is useful for "emacs smudge"