search

danielfm / smudge

Control the Spotify app from within Emacs.
https://asciinema.org/a/218654
GNU General Public License v3.0
309 stars 47 forks source link

Image support #65

Open jkdufair opened 3 years ago

jkdufair commented 3 years ago

@danielfm I thought this could be fun. Let me know what you think.

image
jkdufair commented 3 years ago

Well this hack doesn't hold up very well to sorting, narrowing, widening etc. I'm gonna close this and mess around some more to find a possibly less hacky way to accomplish this.

jkdufair commented 3 years ago

Hey @danielfm I got this pretty well working! Works for track and playlist search. I ended up putting the image in the left margin so it didn't jam up spacing of the actual table. Adds maybe 1-2 sec to include images. Not too noticeable. Wanna give it a look?

image
danielfm commented 3 years ago

I´ll try this later. I think we should expose a flag for activating this feature, which defaults to not fetch images.

Do you agree?

jkdufair commented 3 years ago

I´ll try this later. I think we should expose a flag for activating this feature, which defaults to not fetch images.

Do you agree?

I do agree. There is a config but it defaults to true. Maybe defaulting to false is better. Or maybe default depending on terminal vs gui?