search

danielfrg / mkdocs-jupyter

Use Jupyter Notebook in mkdocs
https://mkdocs-jupyter.danielfrg.com
Apache License 2.0
400 stars 49 forks source link

mkdocs version lower bound #134

Closed giswqs closed 1 year ago

giswqs commented 1 year ago

mkdocs-jupyter requires mkdocs>=1.4.2,<2, which is basically the latest mkdocs version. Is it possible to change the mkdocs lower bound to 1.4.0? There are some other mkdocs plugins that are incompatible with the latest mkdocs yet. I can't use mkdcos-jupyter with other mkdocs plugins together.

josephmcasey commented 1 year ago

Workaround: Although this isn't a solution to the latest release, you should be able to find a much lower bound if you set your mkdocs-jupyter dependency to release 0.22.X.

josephmcasey commented 1 year ago

@giswqs , for the sake of having fidelity on your experience, would you be able to provide additional information on your current environment requirements in addition to which dependencies you are using that have these dependency resolution problems?

giswqs commented 1 year ago

I would like to ignore execute of multiple flies. This feature is only available for mkdocs-jupyter v0.23.0 https://github.com/danielfrg/mkdocs-jupyter/issues/129

Here is my environment setup https://github.com/giswqs/leafmap/blob/master/.github/workflows/docs.yml https://github.com/giswqs/leafmap/blob/master/requirements_docs.txt

It appears that mkdocs-git-revision-date-plugin does not support mkdocs v1.4.2 yet. See https://github.com/giswqs/leafmap/actions/runs/4427004116/jobs/7764004828#step:9:256

giswqs commented 1 year ago

Unless mkdocs-jupyter is using some latest features of mkdocs v1.4.2, I would suggest relaxing the mkdocs version lower bound a little bit, such as v.1.4.0. Not all other mkdocs plugins are up to date with mkdocs v1.4.2.

danielfrg commented 1 year ago

I am ok with that. Can you make a quick PR changing the deps in pyproject.toml?