Unit-test fails on files on Pypi

danielfrg / mkdocs-jupyter

Use Jupyter Notebook in mkdocs

https://mkdocs-jupyter.danielfrg.com

Apache License 2.0

362 stars 45 forks source link

Unit-test fails on files on Pypi #168

Closed Net-Mist closed 9 months ago

Net-Mist commented 9 months ago

Hello ! Why trying to run unit-tests on files uploaded on pypi, the test test_assets_included fails because it can't find the files:

mkdocs-jupyter.css
mkdocs-jupyter.css.map
mkdocs-jupyter.js

Is it expected ?

Thanks a lot !

danielfrg commented 9 months ago

I renamed the files to fix the themes but forgot to update that. I will try to fix it this weekend!

Net-Mist commented 9 months ago

Thanks a lot! Are you planing to update the files uploaded on pypi or release a new version soon ?

danielfrg commented 9 months ago

Yes, I am planning to do a bit more testing/cleanup and release a new version

danielfrg commented 9 months ago

I just made a new release that fixes the tests. Hopefully this helps!

Net-Mist commented 9 months ago

Hello! Thanks a lot! Sadly the tests still fail using Pypi sources. It seems the folder mkdocs_jupyter-0.24.4/src/mkdocs_jupyter/tests/mkdocs/docs is not present in the tar.gz on pypi

danielfrg commented 9 months ago

Ok, just released one more version that fixes that.

Net-Mist commented 9 months ago

Thanks a lot! It now works :+1: