chore: Add back support to py38

danielfrg / mkdocs-jupyter

Use Jupyter Notebook in mkdocs

https://mkdocs-jupyter.danielfrg.com

Apache License 2.0

362 stars 45 forks source link

Closed xmnlab closed 3 months ago

xmnlab commented 3 months ago

This PR aims to add back the support python 3.8.

The estimated EoL for python 3.8 is 2024-10, https://devguide.python.org/versions/

xmnlab commented 3 months ago

hi @danielfrg,

not really sure why cf-pages is failing, but it seems it was failing before.

let me know your thoughts about the changes here in this PR, and if I need to change anything else, please.

danielfrg commented 3 months ago

That fails on PRs for some reason.

This LGTM.

Thank you.

xmnlab commented 3 months ago

Thank you for the review @danielfrg

danielfrg commented 3 months ago

I just released 0.24.7 so you can use this!

xmnlab commented 3 months ago

Awesome!! Really appreciate that!! Thanks!!