search

danielfrg / mkdocs-jupyter

Use Jupyter Notebook in mkdocs
https://mkdocs-jupyter.danielfrg.com
Apache License 2.0
362 stars 45 forks source link

Latest release on PyPi has no associated `.tar.gz` #197

Closed cwognum closed 5 days ago

cwognum commented 2 months ago

Hi @danielfrg, the conda-forge release of v0.24.7 is failing, see https://github.com/conda-forge/mkdocs-jupyter-feedstock/pull/29. This seems to be happening because the latest mkdocs release on PyPi lacks a .tar.gz Source Distribution. Earlier versions do have such a source distribution.

This is causing downstream errors because mkdocs-jupyter <0.24.7 is incompatible with mkdocs >=1.6.0. A simple workaround is to install the latest version of mkdocs-jupyter over pip, but it would be great if this can be fixed soon.

Screenshot

![image](https://github.com/danielfrg/mkdocs-jupyter/assets/28000055/9e683eb4-98ad-41ef-a986-ec0d3c739a5e)

danielfrg commented 2 months ago

It was accidental. I do use rye like you mentioned. I think hatch stuff is just there from the old way of building.

I should update the scripts to generate the .tar.gz too.

I'll try to take a look when I get some time.

cwognum commented 2 months ago

Sorry for deleting my comment, after posting it I realized my question didn't make sense and was hoping to update it before you saw it! :sweat_smile:

The question I intended to ask: Could you explain if this was intentional or accidental (e.g. you forgot to run pnpm run build)? If the .tar.gz Source Distribution will by missing from PyPi from now on, I will look into updating the conda-forge release process to generate the missing files. If I run the steps in RELEASE.md locally, the .tar.gz is generated as expected! I'm not sure why it's missing from PyPi for 0.24.7?

For reference: The deleted comment

@danielfrg Could you explain if this was intentional or accidental (e.g. you forgot to run pnpm run build)? If the .tar.gz Source Distribution will by missing from PyPi from now on, I will look into updating the conda-forge release process to generate the missing files. It seems we would just need to run vite build by running the build script of package.json (with pnpm or the like). In case of the latter, it would be helpful to better understand how the package is released. Looking into [RELEASE.md](https://github.com/danielfrg/mkdocs-jupyter/blob/main/RELEASE.md) and [Taskfile.yml](https://github.com/danielfrg/mkdocs-jupyter/blob/main/Taskfile.yml), it seems you use rye to build and release the Python package, paired with pnpm (& vite) to build the web assets. How does hatch fit in?

danielfrg commented 2 months ago

that was my undestanding as well, that the tar.gz should be generated, maybe its then rye didnt upload it for some reason

cwognum commented 1 month ago

Hey @danielfrg, any update on the above?

chuckwondo commented 1 month ago

Hey @danielfrg, any update on the above?

@danielfrg, I'm interested in getting this sorted out too. Thank you so much for your work on this extension!

danielfrg commented 5 days ago

Fixed on the latest version.

cwognum commented 4 days ago

Thanks @danielfrg !

Fixed for conda-forge with https://github.com/conda-forge/mkdocs-jupyter-feedstock/pull/35 as well.