search

danielfrg / mkdocs-jupyter

Use Jupyter Notebook in mkdocs
https://mkdocs-jupyter.danielfrg.com
Apache License 2.0
402 stars 49 forks source link

Reintroduce `custom_mathjax_url` plugin arg #223

Closed divya-layerhealth closed 4 weeks ago

divya-layerhealth commented 1 month ago

MathJax <= 2.7.9 has a high-severity ReDoS vulnerability.

To mitigate, at the very minimum we should upgrade the default MathJax version to v3.x.

In addition, I noticed that PR https://github.com/danielfrg/mkdocs-jupyter/pull/201 introduced a custom_mathjax_url override, but that it was subsequently removed in PR https://github.com/danielfrg/mkdocs-jupyter/pull/211 -- was there a reason for this/should it be added back?

Happy to make both of these changes myself if that helps!

danielfrg commented 1 month ago

I dont think we had a real reason to remove it tbh. I think we should have it.

If you can get a PR that would be great!

divya-layerhealth commented 1 month ago

Awesome! https://github.com/danielfrg/mkdocs-jupyter/pull/226