search

danielfrg / pelican-jupyter

Pelican plugin for blogging with Jupyter/IPython Notebooks
Apache License 2.0
422 stars 105 forks source link

Adding support for nbconvert configuration #96

Closed croach closed 6 years ago

croach commented 6 years ago

Currently the ipynb plugin creates its own config object, which means that it ignores the nbconvert config that can be found in the user's jupyter profile directory (e.g., ~/.jupyter/jupyter_nbconvert_config.py) or in the current project directory. This means that the user may experience unexpected behavior when using the plugin if they expect nbconvert to honor their configuration. This PR includes a small bit of code which makes sure that the nbconvert config is loaded and then any additional configuration changes needed by the plugin are merged into the user's config.

danielfrg commented 6 years ago

This is very nice, Thanks for the PR!