search

danielfrg / s3contents

Jupyter Notebooks in S3 - Jupyter Contents Manager implementation
Apache License 2.0
248 stars 88 forks source link

Release 0.6.0 #106

Closed ericdill closed 4 years ago

ericdill commented 4 years ago

Will merge once CI passes. Then will upload to pypi and cut a conda-forge release

ericdill commented 4 years ago

Why is this failing....

ericdill commented 4 years ago

@danielfrg should we be getting an access denied on minio?

Screen Shot 2020-09-14 at 7 41 04 AM
ericdill commented 4 years ago

ok i can at least replicate these errors locally when I use pip to install the dependencies, so I've got a prayer of fixing these errors at least

danielfrg commented 4 years ago

@danielfrg should we be getting an access denied on minio?

Yes, I think thats fine because its not passing the credentials, its just to test its alive.

ericdill commented 4 years ago

ok looks like some kind of change in s3fs from 0.5.0 -> 0.5.1 breaks a couple of the tests in here. any idea what could have caused that? cc @martindurant for any support he can maybe lend here

martindurant commented 4 years ago

Perhaps because exceptions now come from aiohttp rather than requests?

martindurant commented 4 years ago

Sorry, both http and s3fs - same goes for botocore -> aiobotocore

ericdill commented 4 years ago

woo tests pass with s3fs 0.5.0. @danielfrg think this looks ok? If so i'll push the new tag and release to pypi and conda-forge. Updating s3fs to 0.5.1 is something that we can deal with in a subsequent release as time permits

ericdill commented 4 years ago

thanks @martindurant :)

danielfrg commented 4 years ago

Yes, lgtm to pin it. We have had to add and remove that pin like 4 times now lol :D