fix versioned buckets: list, rename, delete

danielfrg / s3contents

Jupyter Notebooks in S3 - Jupyter Contents Manager implementation

Apache License 2.0

248 stars 88 forks source link

fix versioned buckets: list, rename, delete #134

Closed Zhell1 closed 3 years ago

Zhell1 commented 3 years ago

make [list, rename, delete] actions on jupyterlab work with versioned buckets (and not display delete markers)
add minio-distributed environement in makefile to make testing versioning possible
add some logging & doc for the pain points I encountered

danielfrg commented 3 years ago

Thank you very much for the PR. I made a couple of small comments on docs and linting but nothing major.

Since this uses MinIO for testing it would be cool to have CI for it, probably in this case it would mean a different github action. It would be interesting but not necessary.

danielfrg commented 3 years ago

Ugh, somethign failing on the environment validation. I will take a look today and rebase here.

danielfrg commented 3 years ago

I fixed the CI issues so I am just going to merge since tests passed before you made the doc fixes.

Thank you for the PR!

Zhell1 commented 3 years ago

Thank you for such a quick reaction on this, you made contributing an awesome experience 🙏

danielfrg commented 3 years ago

Thanks! I will do a release hopefully tomorrow.

danielfrg commented 3 years ago

Version 0.9.0 is released including this.

Zhell1 commented 3 years ago

Thank you for your diligence !