danielfrg / s3contents

Jupyter Notebooks in S3 - Jupyter Contents Manager implementation
Apache License 2.0
248 stars 88 forks source link

Error when using GCS content manager in s3contents==0.9.0 #152

Closed yucensun closed 1 year ago

yucensun commented 1 year ago

Hi,

I'm getting the following error when trying to use the gcs content manager:

`File "***/s3contents/genericmanager.py", line 146, in get return func(path=path, content=content, format=format)

File "***/s3contents/genericmanager.py", line 155, in _get_directory return self._directory_model_from_path(path, content=content)

File "***/s3contents/genericmanager.py", line 222, in _directory_model_from_path self.fs.fs.loop, self.fs.fs._lsdir, prefixed_path

AttributeError: 'GCSFileSystem' object has no attribute '_lsdir'`

Versions: s3contents==0.9.0 fssepc==2022/8/2 gcsfs==2022/8/2 s3fs==2022/8/2

lucienfregosibodyguard commented 1 year ago

Hi I got the same error

it works well to save the notebook in the GCP bucket be I'm not able to list files. Did you find a workaround @yucensun ?

lucienfregosibodyguard commented 1 year ago

Any workaround @danielfrg ?

yucensun commented 1 year ago

@lucienfregosibodyguard this should be fixed by the above pr

danielfrg commented 1 year ago

Fixed on #170