search

danielfrg / s3contents

Jupyter Notebooks in S3 - Jupyter Contents Manager implementation
Apache License 2.0
248 stars 88 forks source link

support for nb7 #168

Closed antoine-galataud closed 1 year ago

antoine-galataud commented 1 year ago

Fixes #167

danielfrg commented 1 year ago

Thanks for the PR. Could you add notebook 7 to the test matrix?

antoine-galataud commented 1 year ago

@danielfrg sorry, very late answer. I just added it to the test matrix.

antoine-galataud commented 1 year ago

Hum of course, 7.0 isn’t released yet. I’ll just make sure it passes with rc2 already.

danielfrg commented 1 year ago

Thank you!

antoine-galataud commented 1 year ago

notebook 7.0 was released last week, I've bumped version in GH action file.

antoine-galataud commented 1 year ago

Last build failed because ipython_genutils dependency is no longer pulled with jupyter notebook 7 (see https://github.com/jupyter/notebook/issues/6153). Workaround: 2 methods are used and they can be easily vendorized so not to break compatibility for notebook < 7 users.

danielfrg commented 1 year ago

Thanks for handling this! I will try to make a release later today.

danielfrg commented 1 year ago

A new version with this is on PyPI!