danielfrg / s3contents

Jupyter Notebooks in S3 - Jupyter Contents Manager implementation
Apache License 2.0
248 stars 88 forks source link

Prioritize jupyter_server import over notebook #184

Closed pjacobsen-utilimarc closed 10 months ago

pjacobsen-utilimarc commented 10 months ago

I am using the jupyterhub/single_user docker image that includes both notebook and jupyter_server. On start up I get the error:

    traitlets.traitlets.TraitError: The 'contents_manager_class' trait of a ServerApp instance expected a subclass of 'jupyter_server.services.contents.manager.ContentsManager', not the S3ContentsManager S3ContentsManager.

I find that S3ContentsManager is type notebook.services.contents.manager.ContentsManager instead because the import of notebook.* didn't fail.

I'm not an expert on the relationship between jupyterlab/server/notebook, but I don't know a situation where you would use notebook while server is also installed

danielfrg commented 10 months ago

Thanks!