danielfrg / s3contents

Jupyter Notebooks in S3 - Jupyter Contents Manager implementation
Apache License 2.0
248 stars 88 forks source link

Allowing ipykernel 5.x #66

Closed AbdealiLoKo closed 5 years ago

AbdealiLoKo commented 5 years ago

I notice that the requirements say ipykernel<5 https://github.com/danielfrg/s3contents/blob/9f9e702b37a7e3395e48af435078ace8d246f7bf/requirements.txt#L2

Any reason for limiting the ipykernel version. From history, I see https://github.com/danielfrg/s3contents/pull/48 saying it was needed as the jupyter > jupyter-console is a dependency https://github.com/danielfrg/s3contents/pull/49 removing jupyter dependency and using the notebook as dependency - hence removing the need for jupyter-console for ipykernel

So, can this be removed now ?