search

danielfrg / s3contents

Jupyter Notebooks in S3 - Jupyter Contents Manager implementation
Apache License 2.0
248 stars 88 forks source link

s3 read base64 format #85

Closed zac-yang closed 4 years ago

zac-yang commented 4 years ago

First commit, but really liking the library!

Fixes the UTF-8 decoding error when trying to read base64 files (eg images). Draws heavily from: https://github.com/jupyter/notebook/blob/d0a74353e62ad5a5b0141f831c5aa59f8c2933bb/notebook/services/contents/fileio.py#L305-L320

Addresses https://github.com/danielfrg/s3contents/issues/68

danielfrg commented 4 years ago

Thank you!

zac-yang commented 4 years ago

No worries! We're thinking of using this for our JupyterHub deployment, just wondering if you're looking to make a release anytime soon?

danielfrg commented 4 years ago

I will try to do a quick release later today.

danielfrg commented 4 years ago

@yzq89, I just released 0.3.3: https://pypi.org/project/s3contents/0.3.3/ with this fix.

zac-yang commented 4 years ago

@danielfrg thanks very much! If not too much trouble, could I ask for a conda release too?

danielfrg commented 4 years ago

Yes, I was waiting for conda-forge build to pass, it's merged now. Thanks for the PR again, enjoy!