search

danielga / gm_luaerror

A module for Garry's Mod that adds hooks for obtaining errors that happen on the client and server (if activated on server, it also pushes errors from clients).
https://github.com/danielga/gm_luaerror
Other
54 stars 8 forks source link

Unable to sigscan function HandleClientLuaError #3

Closed Mista-Tea closed 7 years ago

Mista-Tea commented 7 years ago

Tomorrow's GMod update includes changes to the C++ API and/or patches some exploits. At any rate, the update has broken the gmsv_luaerror module:

[ERROR] unable to sigscan function HandleClientLuaError
  1. unknown - [C]:-1
   2. require - [C]:-1
    3. unknown - addons/path/to/my/lua/file.lua:XX

I don't really know much beyond that. Simply require'ing the module will cause the error. I know myself and several others still rely on this module, so if you'd be willing to test out the prerelease branch today or the main branch when the update comes out tomorrow, we'd really appreciate it.

danielga commented 7 years ago

Fixed by the latest commit (version 1.2.4).

Mista-Tea commented 7 years ago

Thanks for taking the time to look into this.

Unfortunately, the latest binary module for Windows seems to crash the server without generating any crash dumps or outputting any information to SRCDS.

I've tried on both a vanilla sandbox server and a live sandbox server that has addons and other modules (bromsock, mysqloo). Both crash using the new Windows server binary.

The crash seems to occur at luaerror.EnableCompiletimeDetour( true ) with just this test code:

require( 'luaerror' )

luaerror.EnableRuntimeDetour( true )
luaerror.EnableCompiletimeDetour( true )
luaerror.EnableClientDetour( true )

hook.Add( 'LuaError', 'test', print )
hook.Add( 'ClientLuaError', 'test', print )
danielga commented 7 years ago

Fixed as well.

MattJeanes commented 7 years ago

As of most recent GMod update this seems to be happening again, I've downloaded latest release (Apr 20) but still seems to happen

[ERROR] unable to sigscan function HandleClientLuaError
  1. unknown - [C]:-1
   2. require - [C]:-1
    3. unknown - addons/abyss/lua/abyss/server/errors.lua:3
     4. include - [C]:-1
      5. LoadFolder - addons/abyss/lua/autorun/abyss.lua:20
       6. unknown - addons/abyss/lua/autorun/abyss.lua:35
danielga commented 7 years ago

Fixed.

MattJeanes commented 7 years ago

Cool thanks man I'll give it a go tomorrow

danielga commented 7 years ago

Also, please create a new issue next time.