Prevent throw when js exceptions should be discarded

danielgek / nativescript-sentry

Sentry java/cocoa for nativescript

Apache License 2.0

27 stars 30 forks source link

Prevent throw when js exceptions should be discarded #30

Closed jeremypele closed 5 years ago

jeremypele commented 5 years ago

Hi,

I just noticed when upgrading the app that the ErrorHandler in the plugin was throwing every catched JS exception, which cause the app to crash. Unless all codebase is wrapped in a try/catch, it's impossible for an application to deal with any error scenario.

Those exceptions should not be thrown out when discardUncaughtJsExceptions is set to true. The exception is already catched and sent to Sentry.

What do you think?

danielgek commented 5 years ago

hey @jeremypele i was about to take it out together, but better have that option, i will merge #27 and then ca you rebase this ?

Good work and Thanks !! Edit, also just don't look at the CI xD

jeremypele commented 5 years ago

@danielgek All done. Thanks for your reactivity 🙏