search

danielgindi / ChartsRealm

A Realm.io module for Charts
Apache License 2.0
133 stars 47 forks source link

Carthage build fails with incompatible deployment target #36

Open kkalisz opened 4 years ago

kkalisz commented 4 years ago

Hi, I have trouble with using Charts Realm alongside with carthage. I'm getting exception during build: Checkouts/ChartsRealm/ChartsRealm/Classes/Data/RealmBarDataSet.swift:14:8: error: compiling for iOS 8.0, but module 'Charts' has a minimum deployment target of iOS 8.4:

I think it's expected behaviour with current configuration, as I checked project settings Charts 3.4.0 = iPhone Deployment target is 8.4 Charts Realm 3.4.0 = iPhone Deployment target is 8.0

So indeed it should not compile because child dependency has bigger target value than library itself, and Carthage is honoring deployment target from project settings

I think that changing deployment target for ChartsReam to 8.4 should fix issue. I can prepare PR, just let me know what you think about that.

Best Regards

liuxuan30 commented 4 years ago

is it from master? I didn't realize such issue there. If this is the truth, I would appreciate if you can create an PR.