search

danielglejzner / ngx-maintenance

Nx Workspace with all outdated & unmaintained Angular libs that are stuck using ViewEngine. Let's make them work with Angular 16+ !
MIT License
20 stars 2 forks source link

Package request #6

Open Jordan-Hall opened 5 months ago

Jordan-Hall commented 5 months ago

While we are working on automation please request packages and we will do them manually until we are ready

kirillgroshkov commented 5 months ago

🙏

Jordan-Hall commented 5 months ago
  • [ ] @ionic-native/in-app-purchase
  • [ ] @ionic-native/core

🙏

Have you transfered to the new scope @awesome-cordova. It looks like https://danielsogl.gitbook.io/awesome-cordova-plugins/in-app-purchase-2-1 and core is just @awesome-cordova/core we happy to take a look if this isn't case and unmaintained

kirillgroshkov commented 5 months ago

Have you transfered to the new scope @awesome-cordova. It looks like https://danielsogl.gitbook.io/awesome-cordova-plugins/in-app-purchase-2-1 and core is just @awesome-cordova/core we happy to take a look if this isn't case and unmaintained

@awesome-cordova/core - yes, but https://danielsogl.gitbook.io/awesome-cordova-plugins/in-app-purchase-2-1 is based on a different IAP plugin: https://github.com/j3k0/cordova-plugin-purchase vs https://github.com/AlexDisler/cordova-plugin-inapppurchase

We have migrated everything else, but this

Jordan-Hall commented 5 months ago

So to be clear it's https://github.com/AlexDisler/cordova-plugin-inapppurchase is the one you are requesting?

Will go back through the repo and find the original plugin that uses the API

Martinspire commented 5 months ago

Only really updated to angular 14 but has a lot of useful pipes to use (especially in angular flow) There's a few alternatives that remove angular dependency or update the packages, but its not really actively maintained anymore or extended. And it likely could use a fresh coat of paint. Preferably performance-wise, but just having it actively updated so it isn't an issue when you update Angular would be neat. I still think we need more packages like these that offer a few neat features so that you don't need to reinvent the wheel yourself

malek-itani commented 5 months ago

https://github.com/DanielYKPan/date-time-picker

kirillgroshkov commented 5 months ago

So to be clear it's https://github.com/AlexDisler/cordova-plugin-inapppurchase is the one you are requesting?

Will go back through the repo and find the original plugin that uses the API

Ok, after checking a bit deeper I think we can disregard my request. Because @ionic-native/in-app-purchase is simply a wrapper around https://github.com/AlexDisler/cordova-plugin-inapppurchase, we can just copy-paste its code, or wrap the original plugin in a different way and not use @ionic-native/in-app-purchase at all.

Thanks for helping me realize that :)

Jordan-Hall commented 5 months ago

9 will bring this one in. This includes @eneajaho standalone migration! its based of his fork for PR

Jordan-Hall commented 5 months ago

Merged and release

dominikkurenda commented 5 months ago
s7jones commented 5 months ago

I'd like to request this one:

I don't fully understand the process to migrate a library from View Engine to Ivy.

If you have any steps/tutorial on how to do this manually then I may be able to do it myself and open a PR to this repository. Thanks.

Jordan-Hall commented 5 months ago

Sorry didn't mean to close this. @s7jones this is now added. We will keep it updated.