danielgmyers / flux-swf-client

Apache License 2.0
10 stars 3 forks source link

Move workflowDomain parameter of FluxCapacitor.getRemoteWorkflowExecutor() so it's part of the RemoteSwfClientConfig. #128

Closed danielgmyers closed 4 months ago

danielgmyers commented 5 months ago

We don't necessarily need workflowDomain for non-SWF backends.

We already put other swf-specific parameters in RemoteSwfClientConfig, so this parameter should go there as well.

Users who want to use the same remote region with different domains should simply define different "endpoint IDs" for each domain.

It looks like this parameter isn't being honored anyway; the underlying RemoteWorkflowExecutorImpl actually pulls it from FluxCapacitorConfig. It's probably worth not using FluxCapacitorConfig there at all, and get both the swf domain and AutomaticallYTagExecutionsWithTaskList from RemoteSwfClientConfig.