search

danielgmyers / flux-swf-client

Apache License 2.0
10 stars 3 forks source link

Periodic workflow background submitter thread pool missing exception swallower #136

Closed danielgmyers closed 4 days ago

danielgmyers commented 3 weeks ago

ScheduledExecutorService stops rescheduling tasks that were scheduled with scheduleAtFixedRate or scheduleWithFixedDelay if an exception propagates out of them.

We handle this for the decision and activity task pollers by wrapping the scheduled Runnable with ThreadUtils.wrapInExceptionSwallower().

We need to do the same thing for the background pool that schedules periodic workflows: https://github.com/danielgmyers/flux-swf-client/blob/e3f519d5b3800c9d3dbf33766461656825d2c006/flux/src/main/java/software/amazon/aws/clients/swf/flux/FluxCapacitorImpl.java#L673

danielgmyers commented 1 week ago

Planning to release this bugfix for 2.0 (as 2.0.9) and then merge the fix to main-2.1.0.

danielgmyers commented 1 week ago

Published in 2.0.9.

danielgmyers commented 4 days ago

Merged to main-2.1.0.