Options to Share Page

[ProfoundWanderer]

Currently, on game pages, the share link/button doesn't do anything.

Here is the share button currently:

Not exactly sure what share options you would prefer.

I did the below to try out an option for it:

Any idea what you want from the share option? e.g. what options to share to, functionality, etc.

[danielgrijalva]

Hey @ProfoundWanderer sorry for the delay. This looks really awesome! The only thing I'd add is an option to share (copy) the URL itself, for example:

[ProfoundWanderer]

Starting to work on this now. I had some weird issues with my project that I had to fix but everything seems to be working normally now.

[imdoingotherthings]

Interesting feature. I'd like to help out on this if no one is currently working on it.

[danielgrijalva]

Sure @imdoingotherthings go ahead!

[ProfoundWanderer]

@imdoingotherthings I haven't had time to work on it but if you look at my repo I do have it at the point will if you hover it the icons and url show (not a shortened url). It may give you a good starting spot.

[imdoingotherthings]

Nice! I'll take a look at it. Thanks! @danielgrijalva @ProfoundWanderer

[imdoingotherthings]

@ProfoundWanderer @danielgrijalva I'm receiving a 404 error from the backend. Any ideas? So the reason why I'm starting up the server is because I'm receiving 404 errors on the frontend retrieving the data.

I've installed all dependencies and packages from Django, Python3 and React respectively using the .sh file and requirements.txt file.

The issue that I'm currently receiving from both http://localhost:8000/ and http://127.0.0.1:8000/ is this:

Not Found The requested resource was not found on this server.

I've also tested both frontend and backend endpoints using postman, receiving the same 404 error. (i.e. /api/games/popular) given that axios is still listening for http://localhost:8000/.

I'm using python3 manage.py runserver to run the django server.

[ProfoundWanderer]

Not that I know of but give me like 2 hours and I'll make sure the latest was pushed.

On Fri, Nov 1, 2019, 1:27 AM Asai Andrade notifications@github.com wrote:

@ProfoundWanderer https://github.com/ProfoundWanderer @danielgrijalva https://github.com/danielgrijalva I'm receiving a 404 error from the backend. Any ideas? So the reason why I'm starting up the server is because I'm receiving 404 errors on the frontend retrieving the data.

I've installed all dependencies and packages from Django, Python3 and React respectively using the .sh file and requirements.txt file.

The issue that I'm currently receiving from both http://localhost:8000/ http://localhost:8000/ and http://127.0.0.1:8000/ http://127.0.0.1:8000/ is this:

Not Found The requested resource was not found on this server.

I've also tested both frontend and backend endpoints using postman, receiving the same 404 error. (i.e. /api/games/popular) given that axios is still listening for http://localhost:8000/ http://localhost:8000/.

I'm using python3 manage.py runserver to run the django server.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/danielgrijalva/overworld/issues/136?email_source=notifications&email_token=AEOWKPUJ32TDVXFEWDIBSUTQRPD4XA5CNFSM4IJPXKL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC2DP3Q#issuecomment-548681710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOWKPTE6ALYKYJB6FSUWETQRPD4XANCNFSM4IJPXKLQ .

[ProfoundWanderer]

It's the most updated but the only thing I can think of is make sure your api key is good and not over the limit of calls.

On Fri, Nov 1, 2019, 4:00 AM Derrick F freemandc@mymail.vcu.edu wrote:

Not that I know of but give me like 2 hours and I'll make sure the latest was pushed.

On Fri, Nov 1, 2019, 1:27 AM Asai Andrade notifications@github.com wrote:

@ProfoundWanderer https://github.com/ProfoundWanderer @danielgrijalva https://github.com/danielgrijalva I'm receiving a 404 error from the backend. Any ideas? So the reason why I'm starting up the server is because I'm receiving 404 errors on the frontend retrieving the data.

I've installed all dependencies and packages from Django, Python3 and React respectively using the .sh file and requirements.txt file.

The issue that I'm currently receiving from both http://localhost:8000/ http://localhost:8000/ and http://127.0.0.1:8000/ http://127.0.0.1:8000/ is this:

Not Found The requested resource was not found on this server.

I've also tested both frontend and backend endpoints using postman, receiving the same 404 error. (i.e. /api/games/popular) given that axios is still listening for http://localhost:8000/ http://localhost:8000/.

I'm using python3 manage.py runserver to run the django server.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/danielgrijalva/overworld/issues/136?email_source=notifications&email_token=AEOWKPUJ32TDVXFEWDIBSUTQRPD4XA5CNFSM4IJPXKL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC2DP3Q#issuecomment-548681710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOWKPTE6ALYKYJB6FSUWETQRPD4XANCNFSM4IJPXKLQ .

[imdoingotherthings]

This is probably the issue. I haven't injected my api key. I'll give that a shot. Thanks! @ProfoundWanderer

[danielgrijalva]

@imdoingotherthings any updates? 😮

[nobi1007]

Hey @danielgrijalva can I work on this issue, if yes, please let me know what url-shortener you would suggest !

[nobi1007]

This is how it looks if the PR is merged,

[danielgrijalva]

@nobi1007 amazing! thank you, will merge now