search

danielgrijalva / overworld-old

:video_game: Discover, discuss and track your video games.
https://overworld.netlify.com/
120 stars 80 forks source link

added status check for action #143

Closed bovas85 closed 5 years ago

bovas85 commented 5 years ago

Action was not checking for status 404 (this can be extended to other statuses in a map if needed)

codecov[bot] commented 5 years ago

Codecov Report

Merging #143 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #143   +/-   ##
======================================
  Coverage    54.2%   54.2%           
======================================
  Files          89      89           
  Lines        1699    1699           
  Branches       91      91           
======================================
  Hits          921     921           
  Misses        692     692           
  Partials       86      86
Impacted Files Coverage Δ
frontend/src/modules/app/actions.js 24% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb724cd...146a410. Read the comment docs.

bovas85 commented 5 years ago

please review :)

danielgrijalva commented 5 years ago

Hi @bovas85, sorry for the absence and thanks for your PR! what exactly is this fix for? would you mind explaining the details of what you're trying to accomplish/fix?

bovas85 commented 5 years ago

Hey @danielgrijalva this is related to the issue https://github.com/danielgrijalva/overworld/issues/104

danielgrijalva commented 5 years ago

@bovas85 I see! awesome that you got that fixed. Merging now...