danielgrijalva / overworld-old

:video_game: Discover, discuss and track your video games.
https://overworld.netlify.com/
120 stars 80 forks source link

quiet linting errors #146

Closed dreewp closed 5 years ago

dreewp commented 5 years ago

quiets linting errors.

There's still

 Line 35:  The href attribute requires a valid value to be accessible. 
Provide a valid, navigable address as the href value. 
If you cannot provide a valid href, but still need the element to resemble a link, use a button and change it with appropriate styles. 
Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md  jsx-a11y/anchor-is-valid

in the Screenshots component which doesn't appear to be used anywhere either?

codecov[bot] commented 5 years ago

Codecov Report

Merging #146 into master will increase coverage by 0.03%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage    54.2%   54.24%   +0.03%     
==========================================
  Files          89       89              
  Lines        1699     1698       -1     
  Branches       91       91              
==========================================
  Hits          921      921              
+ Misses        692      691       -1     
  Partials       86       86
Impacted Files Coverage Δ
...les/game-browser/components/filterbar/filterBar.js 0% <ø> (ø) :arrow_up:
frontend/src/modules/game-browser/index.js 0% <ø> (ø) :arrow_up:
...ules/game-browser/components/filters/datefilter.js 0% <ø> (ø) :arrow_up:
...d/src/modules/game/components/screenshots/index.js 0% <ø> (ø) :arrow_up:
...tend/src/modules/game/components/actions/Rating.js 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1e19aad...54aa02d. Read the comment docs.

danielgrijalva commented 5 years ago

@akpark sorry for the delay. Thanks for your contribution!