search

danielgrijalva / overworld-old

:video_game: Discover, discuss and track your video games.
https://overworld.netlify.com/
120 stars 80 forks source link

⬆️ support Node v12 #147

Closed bingocaller closed 5 years ago

bingocaller commented 5 years ago

Semantic UI is using Gulp 3, which doesn't play well with Node 12. In order to fix this, I switched from Semantic UI to Fomantic UI, which is an actively maintained community fork of Semantic UI. Fomantic UI uses Gulp 4 and thus plays nicely with Node v12. I also updated a few dependencies based on npm audit, which was reporting quite a few security risks. Tests are still passing.

Fomantic UI on GitHub

codecov[bot] commented 5 years ago

Codecov Report

Merging #147 into master will increase coverage by 4.98%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #147      +/-   ##
=========================================
+ Coverage   49.22%   54.2%   +4.98%     
=========================================
  Files          95      89       -6     
  Lines        1873    1699     -174     
  Branches       80      91      +11     
=========================================
- Hits          922     921       -1     
+ Misses        876     692     -184     
- Partials       75      86      +11
Impacted Files Coverage Δ
...rontend/src/modules/app/components/navbar/index.js 20% <0%> (-8.58%) :arrow_down:
...ntend/src/modules/app/components/register/index.js 9.09% <0%> (-2.03%) :arrow_down:
frontend/src/modules/app/components/login/index.js 8.69% <0%> (-1.84%) :arrow_down:
frontend/src/modules/game-browser/reducers.js 0% <0%> (ø) :arrow_up:
frontend/src/modules/profile/actions.js 0% <0%> (ø) :arrow_up:
frontend/src/modules/app/components/error/index.js 0% <0%> (ø) :arrow_up:
...d/src/modules/game/components/quick-stats/index.js 0% <0%> (ø) :arrow_up:
.../modules/settings/components/edit-profile/index.js 0% <0%> (ø) :arrow_up:
frontend/src/modules/game/actions.js 0% <0%> (ø) :arrow_up:
...ontend/src/modules/app/components/ratings/index.js 0% <0%> (ø) :arrow_up:
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56c3d20...e209e18. Read the comment docs.