danielgrijalva / overworld-old

:video_game: Discover, discuss and track your video games.
https://overworld.netlify.com/
120 stars 80 forks source link

Step in the right direction? #157

Closed imdoingotherthings closed 4 years ago

imdoingotherthings commented 5 years ago

@ProfoundWanderer @danielgrijalva

For the social media icons, what is it that we'd like to do when a user clicks on them? As of now, the social media icons simply link back to the netlify address + the game. Example: https://overworld.netlify.com/games/remnant-from-the-ashes Also, is that the link we want to copy?

I've also install a package for react called react-copy-to-clipboard to copy the link/text. I'd like to clean most of code up, especially the styling. Perhaps move it to a dedicated css file or if there's one already for the component, I'll move it there.

Also, I'm having issues with axios loading the .env.default file which uses the port 8000. However for this feature I just found the endpoints, disabled the axios.default, and injected localhost:8000 to the endpoints. Not a major concern. I put everything back to how it was. In terms of axios and the endpoints.

codecov[bot] commented 5 years ago

Codecov Report

Merging #157 into master will decrease coverage by 0.32%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   55.77%   55.44%   -0.33%     
==========================================
  Files          89       89              
  Lines        1698     1708      +10     
  Branches       91       92       +1     
==========================================
  Hits          947      947              
- Misses        668      677       +9     
- Partials       83       84       +1
Impacted Files Coverage Δ
...ntend/src/modules/game/components/actions/index.js 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4fd5c8d...92eb349. Read the comment docs.

danielgrijalva commented 5 years ago

For the social media icons, what is it that we'd like to do when a user clicks on them?

The Twitter button should open a new window similar to the Tweet Button. The pre-filled text should read "Check game on Overworld! link to the game" or something like that. I'm not very familiar with Facebook so I don't know how they handle sharing, but I'm sure something similar can be achieved.

I've also install a package for react called react-copy-to-clipboard to copy the link/text.

Great! thanks 👍

I'd like to clean most of code up, especially the styling. Perhaps move it to a dedicated css file or if there's one already for the component, I'll move it there.

Please do! It'd be very appreciated by me and other devs. It's hard to maintain a standard code style with open source projects 😅

Also, I'm having issues with axios loading the .env.default file which uses the port 8000. However for this feature I just found the endpoints, disabled the axios.default, and injected localhost:8000 to the endpoints. Not a major concern.

I'm not sure if I fully understood this part but I'm glad it's not a major concern.

Thanks @imdoingotherthings ❤️