search

danielgrijalva / overworld-old

:video_game: Discover, discuss and track your video games.
https://overworld.netlify.com/
120 stars 81 forks source link

Sign up page #162

Closed danielgrijalva closed 4 years ago

danielgrijalva commented 4 years ago

Is your feature request related to a problem? Please describe. Right now users can only sign up from the Get Started button located in the landing page. There’s no independant /signup page where users can directly create their account.

Describe the solution you'd like Besides having that button in the landing page, it’d be good to have a separate sign up page with a form.

Additional context

image

nad0m commented 4 years ago

Hi @danielgrijalva, I'm interested in working on this feature. Possibly #163 as well. Are there any UI or theme requirements? I checked letterboxd.com and they seemed to be doing their sign in/up modally as well so I can't really draw any inspiration from it. :)

danielgrijalva commented 4 years ago

@nad0m sure, I will assign this and #163 to you.

About the UI mockups… I was thinking of just putting the modals “in-line” in the /login and /signup pages (hopefully you understand what I mean by in-line 😅). Just the same forms, nothing fancy really.

I would add a <Backdrop /> component as well just to pretty things up.

danielgrijalva commented 4 years ago

@nad0m any updates?

PathakPratik commented 4 years ago

I could help complete this if it's available! :smiley:

danielgrijalva commented 4 years ago

Go ahead @PathakPratik 👍

PathakPratik commented 4 years ago

signuppage

How does this look? Any suggestions?

danielgrijalva commented 4 years ago

@PathakPratik I like it! but I’m not sure about the backdrop… it makes the form look a bit off and misplaced 🤔

PathakPratik commented 4 years ago

Agreed. Even I thought so. That's why I was asking for an opinion.

PathakPratik commented 4 years ago

I have explored some alternative design options. Please help me decide what looks better. Or you could suggest something. Once we decide what skeleton we could go with, then will fine-tune further on it.

PathakPratik commented 4 years ago

signup1 signup2 signup3 signup4

danielgrijalva commented 4 years ago

I love the first one and the last! I would probably go with the last one though, because it looks easier to responsify (for mobile devices) 🤔

PathakPratik commented 4 years ago

Turns out both the designs are mobile-friendly. Hence, incorporated the first one for the login page and the last one for the signup page.