search

danielgrijalva / overworld-old

:video_game: Discover, discuss and track your video games.
https://overworld.netlify.com/
120 stars 80 forks source link

Annoying 1Password extension in the <GameSearch /> component #170

Closed danielgrijalva closed 4 years ago

danielgrijalva commented 4 years ago

Context

The 1Password extension (and other password managers like LastPass) have the functionality to autofill your usernames/passwords, and they commonly sit on the side of inputs in case you want to configure something or pick a password manually. This is great and I have nothing against that.

Bug

The problem is that this functionality is “leaking” into the <GameSearch /> component used in the <ChooseFavorites /> component (located at src/modules/settings/components/choose-favorites). Obviously this is unnecessary, annoying and intrusive because sometimes you can’t pick a game. See the images below.

image It’s suggesting to autofill my username here… doesn’t make sense.

image Now I can’t pick the first result because the extension is covering it 🤷‍♂️

Expected behaviour

image

image

The input here should work like it isn’t related to any authentication functionality.

Possible solutions

First of, we can’t tweak any 1Password code. However, the <GameSearch /> component uses the <Search /> module from Semantic UI. Maybe there are some props we can pass it (or remove) to fix this bug.

Also, head over to the semantic-ui-react issues, maybe there’s something related in there.

I’m also open to refactoring this and create our own Search component.

tlaudahl commented 4 years ago

Can I take this? I downloaded 1password just to test this and I was able to get it to work without 1password showing up.

Something I noticed while messing with it is if there are too many results they get cut off and there is no way to scroll or view the results past where its cut off which I could include the fix in my PR or you can create a new issue to address just that

danielgrijalva commented 4 years ago

Fixed by #180