search

danielgrijalva / overworld-old

:video_game: Discover, discuss and track your video games.
https://overworld.netlify.com/
120 stars 80 forks source link

made settings page responsive #186

Closed PathakPratik closed 4 years ago

PathakPratik commented 4 years ago

Made the settings page responsive using semantic UI React 'stackable' property for Grid.

Checked for side effects: None found

This is a small change which is a part of #178

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4f5f381). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #186   +/-   ##
=========================================
  Coverage          ?   69.27%           
=========================================
  Files             ?       89           
  Lines             ?     1585           
  Branches          ?       51           
=========================================
  Hits              ?     1098           
  Misses            ?      455           
  Partials          ?       32
Impacted Files Coverage Δ
.../modules/settings/components/edit-profile/index.js 92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f5f381...ca7afca. Read the comment docs.

danielgrijalva commented 4 years ago

Nice work! didn’t know about the stackable prop. Might have to use that in other components as well.