danielgrijalva / overworld-old

:video_game: Discover, discuss and track your video games.
https://overworld.netlify.com/
120 stars 80 forks source link

Signup and Login pages #187

Closed PathakPratik closed 4 years ago

PathakPratik commented 4 years ago

This PR contains work for #162 and #163:

1) Created /signup page and made Register form independent to use anywhere outside modal 2) Created /login page and made Login form independent to use anywhere outside modal 3) Created a Hook 'useBackdrop' for the repetitive code needed for using Backdrop on any page. 4) Created component 'BackdropFrom' 5) Converted Landing component from class-based to functional for simplifying code using 'useBackdrop' hook. 6) Tested all the functionality is working as before.

Unfortunately, with so many changes many of the tests are failing. I tried to fix them but looks like I am not that skilled with writing tests in jest and enzyme yet :disappointed: ( trying to improve on that ). So any help in that matter will be appreciated. And any feedback is absolutely welcome. :smiley:

codecov[bot] commented 4 years ago

Codecov Report

Merging #187 into master will increase coverage by 22.81%. The diff coverage is 38.46%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #187       +/-   ##
===========================================
+ Coverage   69.27%   92.08%   +22.81%     
===========================================
  Files          89       19       -70     
  Lines        1585      935      -650     
  Branches       51        0       -51     
===========================================
- Hits         1098      861      -237     
+ Misses        455       74      -381     
+ Partials       32        0       -32     
Impacted Files Coverage Δ
backend/games/views.py 77.47% <20.00%> (-12.74%) :arrow_down:
backend/games/fields.py 100.00% <100.00%> (ø)
...c/modules/game/components/loaders/ActionsLoader.js
...nd/src/modules/landing/components/popular/index.js
...ntend/src/modules/game/components/actions/index.js
frontend/src/modules/game/actions.js
...c/modules/frontpage/components/game-list/styles.js
frontend/src/modules/game/reducers.js
frontend/src/modules/app/actions.js
...src/modules/game/components/loaders/TitleLoader.js
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e512945...9e410f3. Read the comment docs.