search

danielgrijalva / overworld-old

:video_game: Discover, discuss and track your video games.
https://overworld.netlify.com/
120 stars 81 forks source link

Genres are undefined #22

Closed danielgrijalva closed 5 years ago

danielgrijalva commented 5 years ago

Describe the bug The genres array is undefined for the game Puyo Puyo Tetris, but this bug probably happens in other games too.

To Reproduce Steps to reproduce the behavior:

  1. Search for "Puyo Puyo Tetris"
  2. Go to its game details page
  3. Click on the "Genres" tab

Expected behavior You should see the genres of the game (Puzzle in this case)

Screenshots image

Additional context The genres are there. Printing to console at mounting works.

J0Miles commented 5 years ago

Hello, I would like to take this issue. I ran through the contributions steps but am having issues getting the backend up. When i run python manage.py migrate


I'm getting:
  from django.urls import path, include
ImportError: cannot import name path
danielgrijalva commented 5 years ago

Hi! which Python version are you using? and what OS?

danielgrijalva commented 5 years ago

The path module is from Django 2.0+, which only works with Python 3.4+, so chances are you are running it with Python 2 :thinking:

https://stackoverflow.com/a/48524457

J0Miles commented 5 years ago

Thanks for the fast reply! I'm using Mac OS Sierra 10.12.6 and have python3 installed but even when i run python3 manage.py migrate i get the same result

J0Miles commented 5 years ago

I followed the steps in the link you provided and got it running. Thank you! Going to look into this issue

danielgrijalva commented 5 years ago

Oh damn, it appears this issue is no longer relevant... we migrated to the IGDB API recently and the error doesn't happen anymore, at least on my end :thinking: can you please confirm this, @NeutralDread?

J0Miles commented 5 years ago

@danielgrijalva was just gonna message you haha. It looks like it was resolved

J0Miles commented 5 years ago

Im seeing the genres populate correctly and no extra errors in console

danielgrijalva commented 5 years ago

Yeah sorry about that, I should've closed the issue :sweat_smile:

Glad you got the project to run though. If you want, you can take on issue #14 or #25. I'll be adding more documentation, issues and guidelines soon so stick around! :smile:

J0Miles commented 5 years ago

No worries 😆 Thanks for the help, and I will check out any other issues i think i could contribute to and keep a look out for future ones!