search

danielgrijalva / overworld-old

:video_game: Discover, discuss and track your video games.
https://overworld.netlify.com/
120 stars 80 forks source link

Mock requests to IGDB API #57

Closed danielgrijalva closed 5 years ago

danielgrijalva commented 5 years ago

As pointed out in #56, I had to temporarily remove tests for the games app as they are hitting the real API and wasting resources/requests.

We should mock the IGDB API to re-integrate these tests. Here's a tutorial: https://realpython.com/testing-third-party-apis-with-mocks/

mikesmith commented 5 years ago

@danielgrijalva, I'm interested in taking this on if you don't mind.

danielgrijalva commented 5 years ago

@mikesmith go ahead!

mikesmith commented 5 years ago

In addition to https://realpython.com/testing-third-party-apis-with-mocks/, I used this article to figure out the mocking: http://engineroom.trackmaven.com/blog/real-life-mocking/

danielgrijalva commented 5 years ago

Fixed by #66