danielgross / whatsapp-gpt

MIT License
3.07k stars 596 forks source link

go/clientConnector: fix signal handling, non-2XX HTTP responses, redundant body reading #16

Open odeke-em opened 1 year ago

odeke-em commented 1 year ago

This change adds proper signal handling by passing in a buffered signal channel to signal.Notify as it mandates at https://pkg.go.dev/os/signal#Notify It also handles non-2XX codes and reports this while printing the content and returning. While here also added resp.Body.Close() to avoid leaking HTTP responses. Also removes redundant bytes.Buffer.ReadFrom, then .String() and string(newMsg) by simply using io/ioutil.ReadAll(resp.Body) given we aren't sure which version of Go being used but really in >=Go1.16, we can use io.ReadAll

Fixes #13 Fixes #14 Fixes #15