search

danielgtaylor / aglio

An API Blueprint renderer with theme support that outputs static HTML
4.75k stars 481 forks source link

Use HTTPS URL on Google Fonts #147

Closed pongstr closed 9 years ago

pongstr commented 9 years ago

Since google fonts are available on SSL maybe use the protocol-relative URL instead?

@import url('//fonts.googleapis.com/css?family=Roboto:400,700|Inconsolata|Raleway:200');

instead of:

@import url('http://fonts.googleapis.com/css?family=Roboto:400,700|Inconsolata|Raleway:200');
danielgtaylor commented 9 years ago

@pongstr thanks for the pull request! Using the protocol-relative URLs means you cannot open the generated HTML locally unless using a web server. What if we just default all of them to HTTPS?

kylef commented 9 years ago

@danielgtaylor I agree with making it HTTPS only. The protocol-relative URL pattern is now seen as an anti-pattern, and if the asset is available with TLS, then you should always use TLS to get it (https).

We've taken this approach in pelican.

pongstr commented 9 years ago

@danielgtaylor @kylef I agree with that 100% sorry I didn't realized that immediately. PR Updated! :)

trobrock commented 9 years ago

What is the eta on this?

danielgtaylor commented 9 years ago

Sorry about that, I was out on vacation and this dropped from my radar.