search

danielgtaylor / aglio

An API Blueprint renderer with theme support that outputs static HTML
4.75k stars 480 forks source link

Update default theme to use GitHub Markdown CSS #53

Open jgornick opened 10 years ago

jgornick commented 10 years ago

Since some of the markdown styles can get a little whacky, it would be nice if there was a clean template style using the GitHub Markdown CSS from the project: https://github.com/sindresorhus/github-markdown-css.

danielgtaylor commented 10 years ago

Can you give an example of where this will help?

jgornick commented 10 years ago

Notice the formatting of the "quote" section:

markdown-css

... compared to:

http://sindresorhus.com/github-markdown-css/

The difference in font size and weight are much easier to read in the GitHub style versus the default flat theme style.

jgornick commented 10 years ago

Maybe this should turn into a "Create GitHub theme" instead of using different CSS to render the markdown markup.

danielgtaylor commented 10 years ago

I'm not opposed to either a GitHub theme or specific individual changes to the existing themes. I think the quote looks nicer in gray than in a strong black, for example. Maybe if we could enumerate the changes we could discuss which ones makes sense to apply to the default theme.

jgornick commented 10 years ago

@danielgtaylor I've messed around with the theme slightly and by removing the custom fonts, I feel the theme is much cleaner and easier to read. FWIW, the GitHub theme uses: "Helvetica Neue", Helvetica, "Segoe UI", Arial, freesans, sans-serif

Also, yes, by sizing down the blockquote and changing them to be the same size as a paragraph would help too.

Here's a screenshot where I removed the custom fonts in the default theme and resized the blockquote:

retheme

Owumaro commented 9 years ago

Bump, I saw that aglio now allows us to use custom less variables with the default theme (--theme-variables). I wanted to use it to create a github-like theme with the default layout.

However the fonts aren't overridable which makes it impossible.

I think you should move the @base-font, @title-font and @code-font variables into the variables-xxx.less file.

danielgtaylor commented 9 years ago

@Owumaro thanks I meant to move these into the variables files. This will be in the next beta release!

danielgtaylor commented 9 years ago

@Owumaro this is now in the latest beta. I've also tweaked the default blockquote style a little.

Owumaro commented 9 years ago

Thanks, I'll check this out asap