search

danielgtaylor / atom-api-blueprint-preview

Live preview API Blueprint in Atom
MIT License
43 stars 19 forks source link

maxBuffer should be passed to exec() correctly #67

Open sergeimikhailov opened 7 years ago

sergeimikhailov commented 7 years ago

Fixes danielgtaylor/atom-api-blueprint-preview#44

{env, options} was previously incorrectly expanding to "options: {options: {maxBuffer: ...}}" when being passed to child.process.exec()

now it's passed correctly as "options: {maxBuffer: ...}"

maxBuffer is still not "infinity" but at least it is being passed correctly now and works for much bigger files solving "stdout maxBuffer exceeded" issue

flogr commented 6 years ago

@danielgtaylor can this be merged anytime soon? This would solve issues with previewing larger apiblueprints which is not possible at the moment.

sans-github commented 5 years ago

@danielgtaylor can this be merged anytime soon? This would solve issues with previewing larger apiblueprints which is not possible at the moment.

Yes please. Been anxiously looking forward to the resolution.