danielgtaylor / eidolon

Generate JSON or JSON Schema from Refract & MSON data structures
MIT License
6 stars 1 forks source link

Fix empty object crash bug #2

Closed danielgtaylor closed 8 years ago

danielgtaylor commented 8 years ago

This does two things:

  1. Fix a crash when an element is of type object and there is no content, either in the base or any referenced type.
  2. Modify the referencing examples to test a little bit more:
    • Test object1 -> object2 -> object3 inheritance relationship to confirm that deep referencing does indeed work as expected.
    • Test dereferencing when passed-in refract is just a reference and nothing else, i.e. all information is really in the data structures section like is common in API Blueprint.

Example with empty objects (in Attributes Kit):

screen shot 2016-02-16 at 10 41 48

cc @Baggz

Baggz commented 8 years ago

Looks good to me!

Baggz commented 8 years ago

@danielgtaylor

May I ask you to add me to the eidolon NPM package as a collaborator? I would be able to push new versions.

danielgtaylor commented 8 years ago

@Baggz added you (and a few others) as collaborators on npm. Sorry about that!

Baggz commented 8 years ago

Thanks, @danielgtaylor!