search

danielgtaylor / python-betterproto

Clean, modern, Python 3.6+ code generator & library for Protobuf 3 and async gRPC
MIT License
1.54k stars 216 forks source link

Optional fields in proto3 #574

Closed dpkristensen closed 6 months ago

dpkristensen commented 6 months ago

Summary

Unsupported optional fields in proto3

Reproduction Steps

Run the generator on a .proto file using proto3 and an optional field.

Expected Results

Proto file is generated

Actual Results

Message "code generator protoc-gen-python_betterproto hasn't been updated to support optional fields in proto3" is displayed.

System Information

libprotoc 26.0 Python 3.11.7 Name: betterproto Version: 1.2.5 Summary: A better Protobuf / gRPC generator & library Home-page: http://github.com/danielgtaylor/python-betterproto Author: Daniel G. Taylor Author-email: danielgtaylor@gmail.com License: MIT Location: C:\Python311\Lib\site-packages Requires: grpclib, stringcase Required-by:

Checklist

Gobot1234 commented 6 months ago

This is already supported on main

dpkristensen commented 6 months ago

@Gobot1234 When will the update be published? Last update on pypi was 4 years ago.

Gobot1234 commented 6 months ago

I have verified this issue occurs on the latest prelease of betterproto which can be installed using pip install -U --pre betterproto, if possible.

dpkristensen commented 6 months ago

Sorry I misread that text. But my question is about when a new release will occur; pypi shows the CI status is "failing" and I would like not to add a dependency to something which may break in the future.

Gobot1234 commented 6 months ago

There is no current release date for a full release of V2. The CI failing isn't for V2 I wouldn't worry about it

dkbarn commented 5 months ago

I think it's a valid concern for users of this library to ask whether it has been abandoned before fully committing to integrating it into any project. It sounds like all focus is on V2, which is unreleased and only available via the --pre flag. Meanwhile, no features or bugfixes have been backported to V1 in over 4 years. Why is that? It's unusual to expect all users to install your package with --pre indefinitely, while abandoning support of the stable version of the package.