danielgtaylor / python-betterproto

Clean, modern, Python 3.6+ code generator & library for Protobuf 3 and async gRPC
MIT License
1.56k stars 218 forks source link

Regenerating the proto files make the tests fail #640

Open AdrienVannson opened 2 weeks ago

AdrienVannson commented 2 weeks ago

Summary

Regenerating the proto files make the tests fail

Reproduction Steps

Re-generate the files used in the compiler, as documented in the README:

protoc \
    --plugin=protoc-gen-custom=src/betterproto/plugin/main.py \
    --custom_opt=INCLUDE_GOOGLE \
    --custom_out=src/betterproto/lib/std \
    -I /usr/include/ \
    /usr/include/google/protobuf/*.proto

Then, run poe generate and poe test

Expected Results

The tests should pass.

Actual Results

The test_struct test actually fails.

My guess is that the output files of the compiler have been manually edited to change the to_dict and from_dict methods of Struct (see https://github.com/danielgtaylor/python-betterproto/blame/master/src/betterproto/lib/std/google/protobuf/__init__.py#L2225 )

System Information

libprotoc 3.12.4 Python 3.12.6 Name: betterproto Version: 2.0.0b7 Summary: A better Protobuf / gRPC generator & library Home-page: https://github.com/danielgtaylor/python-betterproto Author: Daniel G. Taylor Author-email: danielgtaylor@gmail.com License: MIT Location: /[...]/.venv/lib/python3.12/site-packages Editable project location: [...] Requires: grpclib, python-dateutil, typing-extensions Required-by:

Checklist

Gobot1234 commented 2 weeks ago

Yeah that's just gonna need removing I think or we need a custom generator