search

danielgtaylor / restish

Restish is a CLI for interacting with REST-ish HTTP APIs with some nice features built-in
https://rest.sh/
MIT License
900 stars 74 forks source link

For discussion: x-cli-waiters #199

Closed pyr closed 1 year ago

pyr commented 1 year ago

This is more a discussion topic than an actual issue. I wanted to know if you would be open to adding a mechanism similar to openapi-cli-generator's x-cli-waiters extension.

The fact that it wasn't carried over from the previous project tells me there could be a good reason :-) I'd be happy to take a shot at it if you think it is OK, but wanted to check first.

danielgtaylor commented 1 year ago

@pyr thanks for opening an issue for this! If I'm being honest my intent was always to port that feature over, but I didn't need it at work at the moment and it's fairly complex so it was just further down in the list of priorities. I would love some help getting it brought over.

One note that I had in the back of my mind is that I don't like the matcher's artificial split of the selector vs. argument via #, and we now use a Structured Data Shorthand instead of JMESPath. I would prefer to have a single object which you can query however you like, e.g: request.params.id or request.body.order.id or response.headers.Foo or response.body.orders[0].status.

pyr commented 1 year ago

Thanks! I will resurrect this issue when I get around to it