search

danielgtaylor / restish

Restish is a CLI for interacting with REST-ish HTTP APIs with some nice features built-in
https://rest.sh/
MIT License
717 stars 69 forks source link

fix(api): Do not cache server responses when refreshing API defs #225

Closed wdullaer closed 7 months ago

wdullaer commented 8 months ago

Also ignores any CLI or env parameters passed in when querying for API definitions: only profile specified params are used.

I also took the liberty of refactoring how the options work.

Final note: the tests timeout when ran natively on mac silicon (at least on my machine). They pass in a ubuntu VM.

Fixes #216

codecov[bot] commented 8 months ago

Codecov Report

Merging #225 (13fe1aa) into main (c4befd0) will decrease coverage by 0.02%. The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
- Coverage   76.92%   76.90%   -0.02%     
==========================================
  Files          26       26              
  Lines        3666     3663       -3     
==========================================
- Hits         2820     2817       -3     
  Misses        639      639              
  Partials      207      207
Files Coverage Δ
cli/api.go 72.80% <100.00%> (-0.43%) :arrow_down:
cli/request.go 68.04% <72.00%> (+0.62%) :arrow_up:

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4befd0...13fe1aa. Read the comment docs.

wdullaer commented 7 months ago

No worries, I know you will get to these eventually. Thanks again for all the work on restish. It's a joy to use.