search

danielguerra69 / ubuntu-xrdp

Docker fully implemented Multi User xrdp with xorgxrdp and pulseaudio on Ubuntu 16.04/18.04
MIT License
251 stars 141 forks source link

Reducing layers & fixing reports from hadolint #27

Closed fbartels closed 5 years ago

fbartels commented 5 years ago

Hi,

I've ran the Dockerfile through Hadolint and fixed most of the recommendations (the one I ignored for now is that one not to use apt directly). I also reduced the layers in the builder step since this was giving me 404 messages since apt update and install were in different layers.

danielguerra69 commented 5 years ago

I'm not sure this change is needed. I have had a lot off 404 messages and solved it with using : docker build --no-cache --rm -t termserv .

danielguerra69 commented 5 years ago

Hub docker is doing a build test. Just a sec o.k.

fbartels commented 5 years ago

Yes, building with --no-cache would indeed solve this as well. but by moving apt update and apt install into the same step you won't ever have to need to force a package list update with --no-cache

danielguerra69 commented 5 years ago

It build well on the hub