Helping Rust `impl IntoIterator for [T; N]`

danielhenrymantilla / stackvec-rs

A rust crate to use stack-allocated vectors (to improve performance and/or when there is no std)

https://crates.io/crates/stackvec

MIT License

11 stars 1 forks source link

Helping Rust `impl IntoIterator for [T; N]` #2

Open tesuji opened 3 years ago

tesuji commented 3 years ago

https://github.com/danielhenrymantilla/stackvec-rs/blob/861a123b792da60019a515832a33c8ab9318cc95/src/stackvec/traits/array_into_iter.rs#L61

Use Fully Qualified Path syntax to avoid ambiguous method calls. Fail log on crater: https://crater-reports.s3.amazonaws.com/pr-65819/try%232d88f48ffbed38cc61e388be2b9dbd98efc23097/reg/stackvec-0.2.1/log.txt Rust issue: https://github.com/rust-lang/rust/pull/65819

LukasKalbertodt commented 3 years ago

Just replacing into_iter with iter should also do the trick. This should also produce a lint warning with recent compiler versions.

danielhenrymantilla commented 3 years ago

@lzutao thanks for pointing that out. This is a crate that I haven't had the time to update and revamp in a long time. I'll take care of fixing that regression around this week-end, publish a new version accordingly, and yank the previous ones, to reduce breakage.