search

danielherrerohernando / ohce-kata

Carlos Jiménez @betisman & Daniel Herrero - Award Winning Solution for GuideSmiths 2019 Christmas Challenge
3 stars 0 forks source link

Some proposals #10

Closed Betisman closed 4 years ago

Betisman commented 4 years ago

Some harmless changes. One for clean code and the other just for currifying the greeting and be able to generate awesome functional tests(TM).

No need to merge this... now it's your kata :( but I would like to discuss them, so we both can learn from each other.

danielherrerohernando commented 4 years ago

Totally agree, I really appreciate your changes, I´m about to merge this PR and then the other one pending.