search

danielhers / tupa

Transition-based UCCA Parser
https://danielhers.github.io/tupa
GNU General Public License v3.0
72 stars 24 forks source link

[WIP] Caching + Simplified model #91

Closed OfirArviv closed 3 years ago

danielhers commented 3 years ago

Hi @OfirArviv, is this PR still relevant?

OfirArviv commented 3 years ago

If I remembered correctly we wanted to use BERT directly without the birnn to improve the runtime. Not sure its relevant, as I'm not sure if a little improvement in the runtime will affect it that much. WDYT?

danielhers commented 3 years ago

I think it's worth being done with - there were just a few comments I left, no?

ons. 9. dec. 2020 19.51 skrev OfirArviv notifications@github.com:

If I remembered correctly we wanted to use BERT directly without the birnn to improve the runtime. Not sure its relevant, as I'm not sure if a little improvement in the runtime will affect it that much. WDYT?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/danielhers/tupa/pull/91#issuecomment-741976115, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAJQ3LXOQ7UY224ETS2JLST7BLBANCNFSM4JU227RQ .

OfirArviv commented 3 years ago

I will run it locally to verify it then. Been too long for me to 100% trust it

danielhers commented 3 years ago

@OfirArviv I'm going to archive this repository and continue using only https://github.com/huji-nlp/tupa to avoid duplication, so please create a PR there for these changes if you think they are worth integrating.