search

danielhrisca / asammdf

Fast Python reader and editor for ASAM MDF / MF4 (Measurement Data Format) files
GNU Lesser General Public License v3.0
612 stars 216 forks source link

Concatenation done by GUI has no duplicate channels while done by library has duplicate channel #872

Open lzmkhan opened 1 year ago

lzmkhan commented 1 year ago

Python version

('python=3.9.13 (tags/v3.9.13:6de2ca5, May 17 2022, 16:36:42) [MSC v.1929 64 ' 'bit (AMD64)]') 'os=Windows-10-10.0.19045-SP0' 'numpy=1.24.3' 'asammdf=7.3.12'

Code

MDF version

4.10

Code snippet

please write here the code snippet that triggers the error local_chunk_files=[] local_dbc_paths = [] mdf_dbc_tuples ={ 'CAN':[(dbc, 0) for dbc in local_dbc_paths]} concatenated_mdf = MDF.concatenate(local_chunk_files) scaled_mdf = concatenated_mdf.extract_bus_logging(database_files=mdf_dbc_tuples)

Traceback

please write here the error traceback

Description

The fastest way to debug is to have the original file. For data protection you can use the static method scramble to scramble all text blocks, and send the scrambled file by e-mail.

There is difference between the concatenated-scaled file from asammdf gui and library. Ex: in asammdf GUI we have 67 channels in total, while in the file generated by library has 137 upon inspection i can see there are duplicate channels with same content for multiple channels Can you help me remove this duplicate channels?

danielhrisca commented 1 year ago

The GUI uses the library API so it should be the same result https://github.com/danielhrisca/asammdf/blob/c93de510f8e06526152feefa6d54575b3d29722f/src/asammdf/gui/widgets/batch.py#L765

lzmkhan commented 1 year ago

My Bad, I found out that the parameter consolidated_J1939 for extract_bus_logging() function when set to true produces results exactly as GUI(7.2.0), when I omit the above parameter I am getting the duplicate channels. So my new question, it says in documentation the above parameter is not used. but in version 7.3.12, it is still affecting. So Whether the functionality of this parameter would be set to true by default in future releases?