search

danielhrisca / asammdf

Fast Python reader and editor for ASAM MDF / MF4 (Measurement Data Format) files
GNU Lesser General Public License v3.0
612 stars 216 forks source link

Aligned iter_to_dataframe with raw=False conversion of to_dataframe m… #895

Closed jlyda closed 9 months ago

jlyda commented 10 months ago

Fix for issue https://github.com/danielhrisca/asammdf/issues/893

Aligned iter_to_dataframe with to_dataframe code for conversion with raw=False.

danielhrisca commented 9 months ago

@jlyda please have a look at the development branch code

jlyda commented 9 months ago

Thanks @danielhrisca! But you aligned to_dataframe with iter_to_dataframe as reference. Regarding #893 sample data, the to_dataframe method was fine, but the case differentiation of text_conversion in iter_to_dataframe here: https://github.com/danielhrisca/asammdf/blob/development/src/asammdf/mdf.py#L4048 causes that with mdf.version > 4 and conversion.conversion_type==7 the conversion is skipped. To solve this, my idea was to align iter_to_dataframe with to_dataframe which was working fine for the issue #893.