search

danielhrisca / asammdf

Fast Python reader and editor for ASAM MDF / MF4 (Measurement Data Format) files
GNU Lesser General Public License v3.0
612 stars 216 forks source link

PGN decoding issue #899

Closed MatinF closed 8 months ago

MatinF commented 10 months ago

Hi Daniel, adding this here as well for tracking purposes.

I did some tests in asammdf v7.3.13.dev9 and in asammdf v7.2.0 with some J1939 PGN conversion. It seems that there is an issue with the matching of the J1939 PGN. Specifically, the sample data zip I sent you has a log file containing 'extended OBD2 data' (which can be handled similarly to J1939 data) and a corresponding DBC file.

The data is correctly matched by the DBC if the DBC is modified to have the exact 29-bit CAN ID as the data has. But it should match based on just the 18-bit PGN - which is not happening. It would be great to get a resolution for this.

MatinF commented 8 months ago

I am closing this as it's related to https://github.com/danielhrisca/asammdf/issues/930 which contains more info