search

danielhrisca / asammdf

Fast Python reader and editor for ASAM MDF / MF4 (Measurement Data Format) files
GNU Lesser General Public License v3.0
655 stars 226 forks source link

PGN 0xDA00 decoding not working as expected (OBD2/J1939 in 7.3.16) #932

Closed MatinF closed 1 year ago

MatinF commented 1 year ago

Tested in latest v7.3.16 built GUI, Windows 10.

Sample data sample-test-data.zip

Observed When decoding the attached log file with the attached DBC file, the expected result is to see decoded results for the 0xDA00 PGN across 2 source addresses: 0x15 and 0x18. However, instead asammdf seems to only decode the CAN ID that is matched by the DBC file exactly, i.e. the one with SA 0x15 in the attached example as evident from below:

image

Expected By the nature of PGN decoding, the match should occur for both the ID with SA 0x15 and 0x18 with the attached DBC file.

Hypothesis Perhaps this issue relates to the fact that the PGN 0xDA00 is a bit atypical as it has a PDU Format < 241, which implies that the PGN handling is a bit different as illustrated here.

danielhrisca commented 1 year ago

@MatinF please try the development branch code

MatinF commented 1 year ago

This is fully resolved in the dev code now - would be great to get a new release with this included!